Matthias Clasen [Sat, 9 May 2020 23:27:05 +0000 (19:27 -0400)]
widget: Don't leak a reference when reordering
When reordering a widget that is alrady under the
same parent, we must not take another reference.
Matthias Clasen [Sat, 9 May 2020 13:22:14 +0000 (09:22 -0400)]
window: Remove some dead code
We are not attaching windows anymore.
Daniel Șerbănescu [Sat, 9 May 2020 18:19:28 +0000 (18:19 +0000)]
Update Romanian translation
Florentina Mușat [Sat, 9 May 2020 17:18:59 +0000 (17:18 +0000)]
Update Romanian translation
Kristjan SCHMIDT [Sat, 9 May 2020 10:20:43 +0000 (10:20 +0000)]
Update Esperanto translation
Matthias Clasen [Fri, 8 May 2020 15:50:33 +0000 (15:50 +0000)]
Merge branch 'carlosgc/content-provider-union-write' into 'master'
clipboard: GdkContentProviderUnion should return after writing the first matched format
See merge request GNOME/gtk!1856
Matthias Clasen [Fri, 8 May 2020 15:05:50 +0000 (15:05 +0000)]
Merge branch 'tintou/gsk-transform-autocleanup' into 'master'
gsk: Add GskTransform autocleanup definition
See merge request GNOME/gtk!1859
Matthias Clasen [Fri, 8 May 2020 14:55:46 +0000 (14:55 +0000)]
Merge branch 'gbsneto/css-dequeue-fix' into 'master'
csswidgetnode: Don't check for container
See merge request GNOME/gtk!1861
Matthias Clasen [Fri, 8 May 2020 14:51:59 +0000 (14:51 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1860
Georges Basile Stavracas Neto [Fri, 8 May 2020 13:51:54 +0000 (10:51 -0300)]
csswidgetnode: Don't check for container
The conditions to queue and dequeue a CSS validation
are different; while queueing checks if the widget is
a root, dequeueing checks that AND if the widget is
a container.
GtkWindow is not a GtkContainer anymore, and that is
causing validations to be queued, but never dequeued.
Don't require the widget to be a GtkContainer for
dequeuing.
Matthias Clasen [Fri, 8 May 2020 13:07:29 +0000 (09:07 -0400)]
placeview: Hide the protocols grid when its empty
Seeing just the bold headings at the bottom of the
popover is confusing, so just hide the entire grid
in this case.
Matthias Clasen [Fri, 8 May 2020 12:47:06 +0000 (08:47 -0400)]
droptarget: Fix confusion around ::leave signal
The leave signal should not take any arguments,
don't pass the GdkDrop. Update the documentation,
fix the emission and update users to match.
This was showing up as crash when dragging files
over the places sidebar.
Corentin Noël [Fri, 8 May 2020 07:14:55 +0000 (09:14 +0200)]
gsk: Add GskTransform autocleanup definition
Carlos Garcia Campos [Thu, 7 May 2020 09:21:18 +0000 (11:21 +0200)]
clipboard: GdkContentProviderUnion should return after writing the first matched format
It continues trying with the other providers due to a missing early
return.
Matthias Clasen [Thu, 7 May 2020 02:56:04 +0000 (02:56 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Fix an inspector crash
See merge request GNOME/gtk!1855
Matthias Clasen [Thu, 7 May 2020 02:25:51 +0000 (22:25 -0400)]
Fix an inspector crash
Fix the listmodel semantics of the controller model,
by making get_item return a reference.
This was broken in
4b9e5304cc.
Matthias Clasen [Thu, 7 May 2020 01:40:39 +0000 (01:40 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
modelbutton: Unify activation code paths
See merge request GNOME/gtk!1854
Matthias Clasen [Thu, 7 May 2020 00:25:42 +0000 (20:25 -0400)]
modelbutton: Unify activation code paths
Opening submenus by Enter or Space wasn't working,
because we had different code paths for activation
via keynav and via click. Unify them.
Emmanuele Bassi [Wed, 6 May 2020 22:53:42 +0000 (22:53 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
See merge request GNOME/gtk!1853
Emmanuele Bassi [Wed, 6 May 2020 18:31:07 +0000 (19:31 +0100)]
Annotate gtk_text_child_anchor_get_widgets() correctly
We switched from returning a list to returning a C array, which means we
need to update the introspection annotation and the documentation to
match the implementation.
Emmanuele Bassi [Wed, 6 May 2020 18:28:33 +0000 (19:28 +0100)]
Annotate gdk_motion_event_get_history() correctly
We moved from returning a list to returning a C array, and this requires
a change in the annotations.
Georges Basile Stavracas Neto [Wed, 6 May 2020 22:02:17 +0000 (22:02 +0000)]
Merge branch 'gbsneto/array-clear-func' into 'master'
icontheme: Don't free array element
Closes #2717
See merge request GNOME/gtk!1851
Matthias Clasen [Wed, 6 May 2020 21:47:47 +0000 (21:47 +0000)]
Merge branch 'wip/exalm/polish' into 'master'
Random polish
See merge request GNOME/gtk!1850
Matthias Clasen [Wed, 6 May 2020 21:35:08 +0000 (21:35 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
nodeeditor: Don't use container api on list box rows
See merge request GNOME/gtk!1852
Georges Basile Stavracas Neto [Wed, 6 May 2020 21:06:09 +0000 (18:06 -0300)]
icontheme: Don't free array element
When setting a clear function on a GArray, unlike
most other places, this free func is expected to
*not* free the array element itself -- only its
contents.
Don't free the array element.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2717
Matthias Clasen [Wed, 6 May 2020 21:03:12 +0000 (17:03 -0400)]
nodeeditor: Don't use container api on list box rows
GtkListBoxRow is not a container anymore.
Alexander Mikhaylenko [Wed, 6 May 2020 20:29:33 +0000 (01:29 +0500)]
widget-factory: Remove duplicate margin-start
Alexander Mikhaylenko [Wed, 6 May 2020 20:29:20 +0000 (01:29 +0500)]
widget-factory: Align spinbutton in the list on page 2
Alexander Mikhaylenko [Wed, 6 May 2020 20:21:26 +0000 (01:21 +0500)]
video: Use more appropriate revealer transition
Matthias Clasen [Wed, 6 May 2020 20:13:22 +0000 (20:13 +0000)]
Merge branch 'gbsneto/fix-text-child-header' into 'master'
textchild: Include <gtk/gtkwidget.h>
See merge request GNOME/gtk!1846
Matthias Clasen [Wed, 6 May 2020 20:02:27 +0000 (20:02 +0000)]
Merge branch 'master.struct.msvc' into 'master'
gtk/gtkaccelgroup.c: Fix build on Visual Studio
See merge request GNOME/gtk!1785
Matthias Clasen [Wed, 6 May 2020 20:01:45 +0000 (20:01 +0000)]
Merge branch 'wip/exalm/row' into 'master'
placesview: Stop using gtk_container_add() for GtkListBoxRow
See merge request GNOME/gtk!1849
Alexander Mikhaylenko [Wed, 6 May 2020 20:01:12 +0000 (01:01 +0500)]
adwaita: Remove a redundant -gtk-icon-shadow: none
Buttons have no icon shadows anymore anyway.
Alexander Mikhaylenko [Wed, 6 May 2020 19:59:44 +0000 (00:59 +0500)]
adwaita: Don't style window menu button anymore
Those were removed with the introduction of GtkWindowControls, no need to
exclude them from the round style anymore.
Alexander Mikhaylenko [Wed, 6 May 2020 19:37:55 +0000 (00:37 +0500)]
adwaita: Use tabular figures where appropriate
Port
82b9be3297db7baeb605c286b01978bab02b5373 from GTK3.
Matthias Clasen [Wed, 6 May 2020 19:25:32 +0000 (19:25 +0000)]
Merge branch 'drop-click-gesture-area' into 'master'
gestureclick: Drop the area
See merge request GNOME/gtk!1847
Matthias Clasen [Wed, 6 May 2020 19:24:58 +0000 (19:24 +0000)]
Merge branch 'master-disable-introspection' into 'master'
CI: disable introspection with mingw to avoid flaky builds
See merge request GNOME/gtk!1848
Christoph Reiter [Wed, 6 May 2020 19:19:52 +0000 (21:19 +0200)]
CI: use bash style variable expansion for the mingw cache key
It doesn't understand the powershell syntax which leads to the cache
key being empty which leads to cache restore being skipped
which leads to slow builds not using ccache.
See https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2747
Jakub Steiner [Wed, 6 May 2020 19:22:27 +0000 (19:22 +0000)]
Merge branch 'wip/jimmac/HC-focus' into 'master'
HC: more contrasty focus rings
See merge request GNOME/gtk!1845
Alexander Mikhaylenko [Wed, 6 May 2020 19:19:03 +0000 (00:19 +0500)]
adwaita: Make popover border transparent
Port
379669b153595fd1a33b200f6b08e7d5ba0407f4 from GTK3.
Matthias Clasen [Wed, 6 May 2020 19:15:31 +0000 (19:15 +0000)]
Merge branch 'abolish-size-allocate' into 'master'
Abolish size allocate
Closes #2705
See merge request GNOME/gtk!1833
Alexander Mikhaylenko [Wed, 6 May 2020 19:15:19 +0000 (00:15 +0500)]
adwaita: Update app icon shadow
Port
f95f3c707aa5a4b1c7b76b2bb43a43519eaf9433 from GTK3.
Alexander Mikhaylenko [Wed, 6 May 2020 17:10:16 +0000 (22:10 +0500)]
placesview: Stop using gtk_container_add() for GtkListBoxRow
Matthias Clasen [Wed, 6 May 2020 19:08:36 +0000 (15:08 -0400)]
Update CONTRIBUTING.md
Point to discourse, rather than mailing lists.
Based on a suggestion by sujiniku,
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1763
Matthias Clasen [Wed, 6 May 2020 19:01:25 +0000 (19:01 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
keymap: Remove leftover code
See merge request GNOME/gtk!1844
Christoph Reiter [Wed, 6 May 2020 18:33:46 +0000 (20:33 +0200)]
CI: disable introspection with mingw to avoid flaky builds
g-i has started to fail and it's not clear why, so disable it for
now to keep the build green.
See https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/340
Matthias Clasen [Wed, 6 May 2020 18:32:09 +0000 (18:32 +0000)]
Merge branch 'wip/jimmac/dark-seuggested' into 'master'
Adwaita: tone down suggested focus ring for dark
See merge request GNOME/gtk!1843
Matthias Clasen [Wed, 6 May 2020 03:12:20 +0000 (23:12 -0400)]
widget: Drop the ::size-allocate signal
This signal is mainly used for bad things, and we
don't want to emit signals during layout if we can
avoid it.
If you are subclassing, you should either use a
layout manager or override the size_allocate vfunc.
If you are using a GtkDrawingArea or GtkGLArea,
use their ::resize signals to learn about size
changes.
Fixes: #2705
Matthias Clasen [Wed, 6 May 2020 02:11:55 +0000 (22:11 -0400)]
tooltipwindow: Stop using the ::size-allocate signal
Instead of connecting to ::size-allocate, call
gtk_native_set_tooltip and rely on the native
to allocate the tooltip window.
Matthias Clasen [Wed, 6 May 2020 01:19:20 +0000 (21:19 -0400)]
tooltipwindow: Drop some dead code
Matthias Clasen [Wed, 6 May 2020 17:56:27 +0000 (13:56 -0400)]
tooltip: Add private api to allocate the window
Add private gtk_tooltip_maybe_allocate() function
and use it from GtkWindow and GtkPopover.
This will let us stop using the ::size-allocate signal,
without having to redo all the tooltip management first.
That will happen later.
Emmanuele Bassi [Mon, 20 Apr 2020 16:10:40 +0000 (17:10 +0100)]
Explicitly update widget a11y bounds when allocating
The a11y machinery is using signal subscription to get notified of size
changes and notify listeners in turn. This is suboptimal for a couple of
reasons:
- if something connects to the GtkWidget::size-allocate signal we need
to emit it; currently, we have an optimization in place that will
skip the signal emission if there are no handlers, and it would be
nice to go through the fast path
- the accessibility implementation is part of GTK, and should not go
through additional hoops like any out-of-tree API consumer
Matthias Clasen [Tue, 5 May 2020 16:15:36 +0000 (12:15 -0400)]
tests: Stop using ::size-allocate
Matthias Clasen [Tue, 5 May 2020 15:57:49 +0000 (11:57 -0400)]
inspector: Stop using ::size-allocate
This signal is going away. Currently, there is no
other way for the inspector to monitor the allocation.
Matthias Clasen [Tue, 5 May 2020 15:54:47 +0000 (11:54 -0400)]
examples: Use GtkDrawingArea::resize
This signal is a replacement for this (ab)use
of the ::size-allocate signal, which is going away.
Matthias Clasen [Tue, 5 May 2020 15:53:25 +0000 (11:53 -0400)]
gtk-demo: Use GtkDrawingArea::resize
This signal is a replacement for this (ab)use
of ::size-allocate.
Matthias Clasen [Tue, 5 May 2020 15:49:00 +0000 (11:49 -0400)]
drawingarea: Add a ::resize signal
This can be used as a replacement for ::size-allocate
to prepare size-dependent resources, like a backing
surface. It mirrors the GtkGLArea::resize signal.
Matthias Clasen [Tue, 5 May 2020 16:11:05 +0000 (12:11 -0400)]
a11y: Avoid a gratitious use of ::size-allocate
The paned widget has a position property, just
use it.
Matthias Clasen [Tue, 5 May 2020 16:12:15 +0000 (12:12 -0400)]
cellarea: Cosmetics
Remove an occurrence of size-allocate in a comment.
Matthias Clasen [Tue, 5 May 2020 16:10:35 +0000 (12:10 -0400)]
treeview: Cosmetic change
Remove an occurrence of size-allocate in a comment.
Matthias Clasen [Tue, 5 May 2020 16:00:15 +0000 (12:00 -0400)]
window: Remove some outdated info from the docs
Remove references to ::size-allocate and ::configure-event
from the docs.
Matthias Clasen [Wed, 6 May 2020 17:15:45 +0000 (13:15 -0400)]
keymap: Remove leftover code
When I removed the 0-termination for the entries for
each keyval, I remove the code initializing the key,
but accidentally left the code that adds it to the
array, so gdk_keymap_get_cached_entries_for_keyval
returns one extra, uninitialized value at the end
of the array. Stop doing that.
Matthias Clasen [Wed, 6 May 2020 18:19:50 +0000 (14:19 -0400)]
gestureclick: Drop the area
This is a rarely used api, and our general trend has been
to use widgets whenever we need an area singled out.
Georges Basile Stavracas Neto [Wed, 6 May 2020 18:13:03 +0000 (15:13 -0300)]
textchild: Include <gtk/gtkwidget.h>
This header is exported, so it needs to include
the gtkwidget.h header with the gtk/ prefix.
This was broken in
289b157e3251581cff91c7bca5f5ed34ff309260
Jakub Steiner [Wed, 6 May 2020 17:28:05 +0000 (19:28 +0200)]
HC: more contrasty focus rings
Matthias Clasen [Wed, 6 May 2020 17:15:45 +0000 (13:15 -0400)]
keymap: Remove leftover code
When I removed the 0-termination for the entries for
each keyval, I remove the code initializing the key,
but accidentally left the code that adds it to the
array, so gdk_keymap_get_cached_entries_for_keyval
returns one extra, uninitialized value at the end
of the array. Stop doing that.
Jakub Steiner [Wed, 6 May 2020 17:02:19 +0000 (19:02 +0200)]
Adwaita: tone down suggested focus ring for dark
Jakub Steiner [Wed, 6 May 2020 16:53:14 +0000 (16:53 +0000)]
Merge branch 'wip/exalm/focus-entries2' into 'master'
Adwaita: Make error/warning entry focus more subtle
See merge request GNOME/gtk!1842
Alexander Mikhaylenko [Wed, 6 May 2020 15:21:56 +0000 (20:21 +0500)]
Adwaita: Make error/warning entry focus more subtle
Add 50% alpha to it like to the main focus color.
Jakub Steiner [Wed, 6 May 2020 15:23:01 +0000 (15:23 +0000)]
Merge branch 'wip/jimmac/suggested-destructive-focus' into 'master'
Adwaita: suggested destrictive button focus
Closes #2704
See merge request GNOME/gtk!1841
Jakub Steiner [Wed, 6 May 2020 14:12:57 +0000 (16:12 +0200)]
Adwaita: suggested destrictive button focus
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2704
Jakub Steiner [Wed, 6 May 2020 13:29:29 +0000 (13:29 +0000)]
Merge branch 'wip/jimmac/global-var' into 'master'
Adwaita: make parser happy wrt global variables
Closes #2703
See merge request GNOME/gtk!1840
Matthias Clasen [Wed, 6 May 2020 12:55:18 +0000 (12:55 +0000)]
Merge branch 'fix-inspector-popover' into 'master'
inspector: Fix css tree popovers
See merge request GNOME/gtk!1838
Jakub Steiner [Wed, 6 May 2020 12:12:44 +0000 (14:12 +0200)]
Adwaita: make parser happy wrt global variables
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2703
Matthias Clasen [Wed, 6 May 2020 03:55:55 +0000 (03:55 +0000)]
Merge branch 'wip/baedert/for-master' into 'master'
Wip/baedert/for master
See merge request GNOME/gtk!1828
Matthias Clasen [Wed, 6 May 2020 03:51:37 +0000 (23:51 -0400)]
inspector: Fix css tree popovers
Adding popovers to a treeview doesn't work. Instead,
attach them to the cssnodetree widget, which is using
a layout manager - popovers work in that case.
Matthias Clasen [Wed, 6 May 2020 00:37:04 +0000 (00:37 +0000)]
Merge branch 'abolish-destroy' into 'master'
Abolish destroy
See merge request GNOME/gtk!1835
Matthias Clasen [Tue, 5 May 2020 20:59:31 +0000 (16:59 -0400)]
widget: Drop the destroy vfunc
We still emit the ::destroy signal, but if you
want a vfunc, use dispose.
Matthias Clasen [Tue, 5 May 2020 20:57:28 +0000 (16:57 -0400)]
gtk-demo: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:52:02 +0000 (16:52 -0400)]
container: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:51:43 +0000 (16:51 -0400)]
placesview: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:51:33 +0000 (16:51 -0400)]
printunixdialog: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:51:24 +0000 (16:51 -0400)]
window: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:51:16 +0000 (16:51 -0400)]
treeview: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:50:59 +0000 (16:50 -0400)]
textview: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:50:49 +0000 (16:50 -0400)]
statusbar: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:50:33 +0000 (16:50 -0400)]
notebook: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:50:21 +0000 (16:50 -0400)]
iconview: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:50:07 +0000 (16:50 -0400)]
shortcutssection: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:49:48 +0000 (16:49 -0400)]
radiobutton: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:49:33 +0000 (16:49 -0400)]
range: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:49:20 +0000 (16:49 -0400)]
spinbutton: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:49:08 +0000 (16:49 -0400)]
viewport: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:48:59 +0000 (16:48 -0400)]
text: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:48:39 +0000 (16:48 -0400)]
modelbutton: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:48:23 +0000 (16:48 -0400)]
label: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:48:11 +0000 (16:48 -0400)]
filechooserbutton: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:47:36 +0000 (16:47 -0400)]
expander: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 20:47:10 +0000 (16:47 -0400)]
combobox: Use dispose instead of destroy
The destroy vfunc is going away.
Matthias Clasen [Tue, 5 May 2020 19:49:30 +0000 (15:49 -0400)]
actionbar: Use dispose instead of destroy
The destroy vfunc is going away.